Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devtools extensions not loading #20791

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Oct 28, 2019

Description of Change

Fixes #20677

According to the docs for chrome.runtime.connect(string extensionId, object connectInfo)
both extensionId and connectInfo arguments are optional, which means that just connectInfo can be passed. We would assume it to be extensionId. It regressed in #16998

Checklist

Release Notes

Notes: Fixed devtools extensions not loading due to "Connect to unknown extension [object Object]" errors.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 28, 2019
@miniak miniak self-assigned this Oct 28, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 29, 2019
@zcbenz zcbenz merged commit 3d56e13 into master Oct 30, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 30, 2019

Release Notes Persisted

Fixed devtools extensions not loading due to "Connect to unknown extension [object Object]" errors.

@zcbenz zcbenz deleted the miniak/fix-devtools-extensions branch October 30, 2019 05:46
@trop
Copy link
Contributor

trop bot commented Oct 30, 2019

I was unable to backport this PR to "7-0-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Oct 30, 2019

I have automatically backported this PR to "8-x-y", please check out #20842

@trop
Copy link
Contributor

trop bot commented Oct 30, 2019

@miniak has manually backported this PR to "7-0-x", please check out #20844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devtools extensions no longer load in 7.0.0
3 participants